Closed rambohe-ch closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 53.05%. Comparing base (
43704c9
) to head (0773528
). Report is 2 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
lgtm, but I still have questions for some of the modifications. @rambohe-ch PTAL
Issues
1 New issue
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code
@Congrool I have fixed you comments, PTAL
/rerun
/approve /lgtm
What type of PR is this?
/kind feature
What this PR does / why we need it:
ResponseFilter return
watch.Deleted
event back to clients when Standalone object is filtered to nil in ObjectFilters.by the way, this feature will be helpful for all ObjectFilters, not only for
nodeportisolation
filter.Which issue(s) this PR fixes:
Fixes #1994
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note