openyurtio / openyurt

OpenYurt - Extending your native Kubernetes to edge(project under CNCF)
https://openyurt.io
Apache License 2.0
1.68k stars 391 forks source link

add forwardkubesvctraffic filter and adapt server certificate #1996

Closed rambohe-ch closed 3 months ago

rambohe-ch commented 3 months ago

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line: /kind bug /kind documentation /kind enhancement /kind good-first-issue /kind feature /kind question /kind design /sig ai /sig iot /sig network /sig storage

/kind feature

What this PR does / why we need it:

add a new ObjectFilter named forwardkubesvctraffic in order to improve transparent management mechanism for control traffic from edge to cloud.

the detail design of this filter, the proposal link is here: https://github.com/openyurtio/openyurt/pull/1975

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 51.57895% with 46 lines in your changes are missing coverage. Please review.

Project coverage is 53.11%. Comparing base (b4cfa75) to head (9f157d9).

Files Patch % Lines
pkg/yurthub/certificate/server/server.go 19.51% 32 Missing and 1 partial :warning:
pkg/yurthub/filter/forwardkubesvctraffic/filter.go 75.47% 9 Missing and 4 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1996 +/- ## ========================================== + Coverage 53.08% 53.11% +0.02% ========================================== Files 175 176 +1 Lines 20910 21000 +90 ========================================== + Hits 11100 11154 +54 - Misses 8861 8892 +31 - Partials 949 954 +5 ``` | [Flag](https://app.codecov.io/gh/openyurtio/openyurt/pull/1996/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openyurtio) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/openyurtio/openyurt/pull/1996/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openyurtio) | `53.11% <51.57%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openyurtio#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

YTGhost commented 3 months ago

/rerun

Congrool commented 3 months ago

e2e failed when preparing environment for autonomy test

+ kubectl wait --for=condition=Ready pod/yurt-e2e-test-nginx-openyurt-e2e-test-worker --timeout=240s
Error from server (NotFound): pods "yurt-e2e-test-nginx-openyurt-e2e-test-worker" not found
make: *** [Makefile:114: e2e-tests] Error 1
Error: Process completed with exit code 2.

/rerun

Congrool commented 3 months ago

/lgtm

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

Congrool commented 3 months ago

/rerun

Congrool commented 3 months ago

e2e test error log:

+ kubectl wait --for=condition=Ready pod/yurt-e2e-test-nginx-openyurt-e2e-test-worker --timeout=240s
Error from server (NotFound): pods "yurt-e2e-test-nginx-openyurt-e2e-test-worker" not found
make: *** [Makefile:114: e2e-tests] Error 1
Error: Process completed with exit code 2.