Refactor PoolService API

zyjhtangtang commented 3 months ago

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line: /kind feature /sig network

What this PR does / why we need it:

This Pull Request introduces significant changes to the PoolService API.

Removed the poolName field from the PoolService spec. PoolServices will now be identified using a label: openyurt.io/pool-name.
Removed the renew field from the PoolService spec.

Does this PR introduce a user-facing change?

YES

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.64%. Comparing base (e80164a) to head (dfd8a16).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2003 +/- ## ========================================== + Coverage 54.60% 54.64% +0.04% ========================================== Files 176 176 Lines 17100 17100 ========================================== + Hits 9337 9345 +8 + Misses 6809 6801 -8 Partials 954 954 ``` | [Flag](https://app.codecov.io/gh/openyurtio/openyurt/pull/2003/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openyurtio) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/openyurtio/openyurt/pull/2003/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openyurtio) | `54.64% <ø> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openyurtio#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rambohe-ch commented 3 months ago

poolservice.openyurt.io/pool-name

how about rename poolservice.openyurt.io/pool-name to openyurt.io/pool-name? I think that openyurt.io/pool-name is more clearer.

zyjhtangtang commented 3 months ago

poolservice.openyurt.io/pool-name

how about rename poolservice.openyurt.io/pool-name to openyurt.io/pool-name? I think that openyurt.io/pool-name is more clearer.