1908 - Githubissues

MundaneImmortal commented 3 months ago

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line: /kind bug /kind documentation /kind enhancement /kind good-first-issue /kind feature /kind question /kind design /sig ai /sig iot /sig network /sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1908

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 54.71%. Comparing base (56b874c) to head (8765ca6). Report is 4 commits behind head on master.

Files	Patch %	Lines
...manager/controller/nodepool/nodepool_controller.go	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2007 +/- ## ========================================== + Coverage 53.06% 54.71% +1.64% ========================================== Files 176 177 +1 Lines 21000 17271 -3729 ========================================== - Hits 11144 9450 -1694 + Misses 8902 6849 -2053 - Partials 954 972 +18 ``` | [Flag](https://app.codecov.io/gh/openyurtio/openyurt/pull/2007/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openyurtio) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/openyurtio/openyurt/pull/2007/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openyurtio) | `54.71% <0.00%> (+1.64%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openyurtio#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rambohe-ch commented 3 months ago

@MundaneImmortal Thanks for posting pull request. you need to fix the golangci-lint errors. you can execute make lint command locally to check golangci-lint errors.