openyurtio / openyurt

OpenYurt - Extending your native Kubernetes to edge(project under CNCF)
https://openyurt.io
Apache License 2.0
1.7k stars 401 forks source link

add pool service controller. #2010

Closed zyjhtangtang closed 5 months ago

zyjhtangtang commented 6 months ago

What type of PR is this?

/kind feature /sig network

What this PR does / why we need it:

The first-level controller for the multi-region load balancer.

Does this PR introduce a user-facing change?

YES
codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 73.75000% with 147 lines in your changes are missing coverage. Please review.

Project coverage is 55.24%. Comparing base (839a52a) to head (1df5657). Report is 1 commits behind head on master.

Files Patch % Lines
...rset/loadbalancerset/loadbalancerset_controller.go 65.88% 60 Missing and 27 partials :warning:
...oller/loadbalancerset/loadbalancerset/predicate.go 75.38% 16 Missing and 16 partials :warning:
...ler/loadbalancerset/loadbalancerset/annotations.go 79.48% 8 Missing and 8 partials :warning:
...r/loadbalancerset/loadbalancerset/event_handler.go 83.56% 9 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2010 +/- ## ========================================== + Coverage 54.71% 55.24% +0.53% ========================================== Files 177 183 +6 Lines 17271 17831 +560 ========================================== + Hits 9450 9851 +401 - Misses 6849 6953 +104 - Partials 972 1027 +55 ``` | [Flag](https://app.codecov.io/gh/openyurtio/openyurt/pull/2010/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openyurtio) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/openyurtio/openyurt/pull/2010/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openyurtio) | `55.24% <73.75%> (+0.53%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openyurtio#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zyjhtangtang commented 5 months ago

/rerun

rambohe-ch commented 5 months ago

@zyjhtangtang I think the repo of controllers about MultiPoolLoadBalancer should be constructed as following:

controller:
|
-- loadbalancerset:
   |
   -- loadbalancerset:
   |
   -- enslb:
   | 
   -- viplb:
zyjhtangtang commented 5 months ago

@zyjhtangtang I think the repo of controllers about MultiPoolLoadBalancer should be constructed as following:

controller:
|
-- loadbalancerset:
   |
   -- loadbalancerset:
   |
   -- enslb:
   | 
   -- viplb:

Thanks for the suggestion, I have adjusted the relevant directory structure

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

rambohe-ch commented 5 months ago

/lgtm