openyurtio / openyurt

OpenYurt - Extending your native Kubernetes to edge(project under CNCF)
https://openyurt.io
Apache License 2.0
1.7k stars 401 forks source link

modify status of poolservice #2019

Closed zyjhtangtang closed 5 months ago

zyjhtangtang commented 5 months ago

What type of PR is this?

/kind design /sig network

What this PR does / why we need it:

Add two fields AggregateToAnnotations and AggregateToLabels to status

Does this PR introduce a user-facing change?

YES

other Note

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.31%. Comparing base (20594f8) to head (5e1af9d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2019 +/- ## ======================================= Coverage 55.31% 55.31% ======================================= Files 183 183 Lines 17831 17831 ======================================= Hits 9863 9863 Misses 6942 6942 Partials 1026 1026 ``` | [Flag](https://app.codecov.io/gh/openyurtio/openyurt/pull/2019/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openyurtio) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/openyurtio/openyurt/pull/2019/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openyurtio) | `55.31% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openyurtio#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rambohe-ch commented 5 months ago

@zyjhtangtang I think it is a good idea to sync info from PoolService.Status to upstream Service annotations and labels instead of syncing from annotations/labels to annotations/labels.

rambohe-ch commented 5 months ago

/lgtm