openyurtio / openyurt

OpenYurt - Extending your native Kubernetes to edge(project under CNCF)
https://openyurt.io
Apache License 2.0
1.68k stars 388 forks source link

improve pod webhook for adapting hostnetwork mode nodepool #2050

Closed rambohe-ch closed 1 month ago

rambohe-ch commented 1 month ago

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line: /kind bug /kind documentation /kind enhancement /kind good-first-issue /kind feature /kind question /kind design /sig ai /sig iot /sig network /sig storage

/kind enhancement

What this PR does / why we need it:

Because of terms in pod.Spec.Affinity.NodeAffinity.RequiredDuringSchedulingIgnoredDuringExecution.NodeSelectorTerms are ORed, not ANDed, so we need to add excludeHostNetworkRequirement for each NodeSelectorTerms.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

rambohe-ch commented 1 month ago

@huangchenzhao PTAL

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.61%. Comparing base (df38199) to head (3fc1b38).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2050 +/- ## ========================================== + Coverage 55.58% 55.61% +0.02% ========================================== Files 186 186 Lines 18057 18072 +15 ========================================== + Hits 10037 10050 +13 - Misses 6995 6996 +1 - Partials 1025 1026 +1 ``` | [Flag](https://app.codecov.io/gh/openyurtio/openyurt/pull/2050/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openyurtio) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/openyurtio/openyurt/pull/2050/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openyurtio) | `55.61% <100.00%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openyurtio#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rambohe-ch commented 1 month ago

@zyjhtangtang PTAL

zyjhtangtang commented 1 month ago

/LGTM