Closed rambohe-ch closed 2 weeks ago
Attention: Patch coverage is 0%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 56.15%. Comparing base (
3713163
) to head (8d3d5f4
). Report is 4 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
pkg/yurtmanager/webhook/node/v1/node_handler.go | 0.00% | 1 Missing :warning: |
...kg/yurtmanager/webhook/pod/v1alpha1/pod_handler.go | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/LGTM
/LGTM
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
Because of Group is empty for
node
andpod
resource, so webhook paths are not registered correctly. The detail logs are as following:so add a new func named
RegisterIndependentWebhook
to deal with these kind of webhook registration.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note