openyurtio / raven

provide layer 3 and layer 7 network connectivity among pods in different physical regions
Apache License 2.0
57 stars 37 forks source link

Support github container registry #121

Closed siredmar closed 1 year ago

siredmar commented 1 year ago

Same as openyurtio/openyurt#1575

You need to provide the repository secrets GH_REGISTRY_USERNAME and GH_REGISTRY_PASSWORD containing the username that pushes and a PAT (private access token) from github described in the following docs: https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#authenticating-to-the-container-registry

codecov[bot] commented 1 year ago

Codecov Report

Merging #121 (19062be) into main (7e50082) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #121   +/-   ##
=======================================
  Coverage   42.73%   42.73%           
=======================================
  Files           7        7           
  Lines        1053     1053           
=======================================
  Hits          450      450           
  Misses        513      513           
  Partials       90       90           
Flag Coverage Δ
unittests 42.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

rambohe-ch commented 1 year ago

Same as openyurtio/openyurt#1575

You need to provide the repository secrets GH_REGISTRY_USERNAME and GH_REGISTRY_PASSWORD containing the username that pushes and a PAT (private access token) from github described in the following docs: https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry#authenticating-to-the-container-registry

@siredmar Env GH_REGISTRY_USERNAME and GH_REGISTRY_PASSWORD are defined as organization envs, so you can use them directly in raven repository.

and would you like to make a pull request to support github container registry?

siredmar commented 1 year ago

@rambohe-ch great using orga secrets. This is already the PR you are looking at.

rambohe-ch commented 1 year ago

/lgtm