Closed huiwq1990 closed 2 years ago
@huiwq1990: GitHub didn't allow me to assign the following users: your_reviewer.
Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: huiwq1990
To complete the pull request process, please assign kadisi
You can assign the PR to them by writing /assign @kadisi
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Merging #100 (931ea54) into master (aaeca3e) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #100 +/- ##
=======================================
Coverage 21.87% 21.87%
=======================================
Files 23 23
Lines 2647 2647
=======================================
Hits 579 579
Misses 1986 1986
Partials 82 82
Flag | Coverage Δ | |
---|---|---|
unittests | 21.87% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
I tried locally and this pr do fix both https://github.com/openyurtio/yurt-app-manager/issues/90 and https://github.com/openyurtio/yurt-app-manager/issues/99 .
@huiwq1990 pull request: https://github.com/openyurtio/yurt-app-manager/pull/101 has updated all_in_one.yaml
file, so i will close this pull request.
Signed-off-by: huiwq1990 huiwq1990@163.com
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #https://github.com/openyurtio/yurt-app-manager/issues/90
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note