Closed rudolf-chy closed 2 years ago
@Rudolf1998: GitHub didn't allow me to assign the following users: your_reviewer.
Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide
Merging #106 (2cc2a86) into master (69c860f) will increase coverage by
0.08%
. The diff coverage isn/a
.:exclamation: Current head 2cc2a86 differs from pull request most recent head c0567c4. Consider uploading reports for the commit c0567c4 to get more accurate results
@@ Coverage Diff @@
## master #106 +/- ##
==========================================
+ Coverage 23.45% 23.53% +0.08%
==========================================
Files 42 42
Lines 4776 4776
==========================================
+ Hits 1120 1124 +4
+ Misses 3504 3500 -4
Partials 152 152
Flag | Coverage Δ | |
---|---|---|
unittests | 23.53% <ø> (+0.08%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
...troller/yurtappdaemon/nodepool_enqueue_handlers.go | 20.00% <0.00%> (+20.00%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@Rudolf1998 please fix the golangci-lint errors.
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rambohe-ch, Rudolf1998
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note