Closed huiwq1990 closed 1 year ago
@huiwq1990: GitHub didn't allow me to assign the following users: your_reviewer.
Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: huiwq1990
To complete the pull request process, please assign huangyuqi
You can assign the PR to them by writing /assign @huangyuqi
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Merging #110 (8146dc9) into master (dbc59e8) will decrease coverage by
0.06%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #110 +/- ##
==========================================
- Coverage 23.53% 23.47% -0.07%
==========================================
Files 42 42
Lines 4776 4776
==========================================
- Hits 1124 1121 -3
- Misses 3500 3502 +2
- Partials 152 153 +1
Flag | Coverage Δ | |
---|---|---|
unittests | 23.47% <ø> (-0.07%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
...manager/controller/nodepool/nodepool_controller.go | 56.75% <0.00%> (-1.02%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Signed-off-by: huiwq1990 huiwq1990@163.com
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #https://github.com/openyurtio/openyurt/issues/953
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note