Closed YTGhost closed 2 years ago
Merging #117 (1b73cb7) into master (b22ba35) will not change coverage. The diff coverage is
n/a
.:exclamation: Current head 1b73cb7 differs from pull request most recent head 8bb7568. Consider uploading reports for the commit 8bb7568 to get more accurate results
@@ Coverage Diff @@
## master #117 +/- ##
=======================================
Coverage 37.37% 37.37%
=======================================
Files 42 42
Lines 4776 4776
=======================================
Hits 1785 1785
Misses 2752 2752
Partials 239 239
Flag | Coverage Δ | |
---|---|---|
unittests | 37.37% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@zzguang PTAL
Generally, it looks good to me except one word of "ingressIps", I am not sure whether "ingressIPs" is better, please check it, thanks!
Generally, it looks good to me except one word of "ingressIps", I am not sure whether "ingressIPs" is better, please check it, thanks!
Yep, you're right. Please take another look
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: YTGhost, zzguang
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@YTGhost , Since the CRD naming is optimized, could you please update the related doc accordingly? Thanks!
@YTGhost , Since the CRD naming is optimized, could you please update the related doc accordingly? Thanks!
ok
@YTGhost , Since the CRD naming is optimized, could you please update the related doc accordingly? Thanks!
Hi, I'm not very familiar with it, so I'd like to ask if it refers to the documentation here?https://github.com/openyurtio/openyurt.io
@YTGhost , Since the CRD naming is optimized, could you please update the related doc accordingly? Thanks!
Hi, I'm not very familiar with it, so I'd like to ask if it refers to the documentation here?https://github.com/openyurtio/openyurt.io
@YTGhost yes, all official documents are hosted in this repo, and can be accessed from website: https://openyurt.io.
Signed-off-by: HIHIA 283304489@qq.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
crd naming optimization
Which issue(s) this PR fixes:
Fixes https://github.com/openyurtio/openyurt/issues/852
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note