Closed River-sh closed 2 years ago
@River-sh: GitHub didn't allow me to assign the following users: your_reviewer.
Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide
Merging #120 (bdd504d) into master (7c799d4) will increase coverage by
0.90%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #120 +/- ##
==========================================
+ Coverage 37.37% 38.27% +0.90%
==========================================
Files 42 42
Lines 4776 4776
==========================================
+ Hits 1785 1828 +43
+ Misses 2752 2704 -48
- Partials 239 244 +5
Flag | Coverage Δ | |
---|---|---|
unittests | 38.27% <ø> (+0.90%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
...daemon/workloadcontroller/deployment_controller.go | 64.92% <0.00%> (+32.08%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rambohe-ch, River-sh
The full list of commands accepted by this bot can be found here.
The pull request process is described here
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rambohe-ch, River-sh
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What type of PR is this?
What this PR does / why we need it:
this PR is used to improve the unite test caverage of yurtappdaemon about workload operator(eg. create, update,delete)
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
```release-note NONE ``` #### other Note