River-sh commented 2 years ago

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line: /kind enhancement

What this PR does / why we need it:

this pr is used to improve the unit test coverage .

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

codecov[bot] commented 2 years ago

Codecov Report

Merging #122 (f03d17d) into master (7c799d4) will increase coverage by 7.76%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
+ Coverage   37.37%   45.14%   +7.76%     
==========================================
  Files          42       42              
  Lines        4776     4776              
==========================================
+ Hits         1785     2156     +371     
+ Misses       2752     2318     -434     
- Partials      239      302      +63

Flag	Coverage Δ
unittests	`45.14% <ø> (+7.76%)`	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...daemon/workloadcontroller/deployment_controller.go	`64.92% <0.00%> (+32.08%)`	:arrow_up:
...anager/controller/uniteddeployment/pool_control.go	`60.74% <0.00%> (+43.92%)`	:arrow_up:
...appmanager/controller/uniteddeployment/revision.go	`50.25% <0.00%> (+47.17%)`	:arrow_up:
...er/uniteddeployment/uniteddeployment_controller.go	`48.16% <0.00%> (+47.24%)`	:arrow_up:
...roller/uniteddeployment/uniteddeployment_update.go	`48.27% <0.00%> (+48.27%)`	:arrow_up:
...teddeployment/uniteddeployment_controller_utils.go	`60.00% <0.00%> (+54.54%)`	:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

rambohe-ch commented 1 year ago

/lgtm /approve

openyurt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, River-sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openyurtio/yurt-app-manager/blob/master/OWNERS)~~ [rambohe-ch] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment