adamzhoul commented 1 year ago

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #129

Special notes for your reviewer:

as issue.

Does this PR introduce a user-facing change?

NONE

openyurt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adamzhoul To complete the pull request process, please assign kadisi You can assign the PR to them by writing /assign @kadisi in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openyurtio/yurt-app-manager/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

rambohe-ch commented 1 year ago

@kadisi PTAL

rambohe-ch commented 1 year ago

@adamzhoul please fix unit tests error.

codecov[bot] commented 1 year ago

Codecov Report

Merging #130 (5dd9963) into master (0b378c5) will increase coverage by 0.06%. The diff coverage is 78.94%.

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
+ Coverage   45.21%   45.27%   +0.06%     
==========================================
  Files          42       42              
  Lines        4782     4793      +11     
==========================================
+ Hits         2162     2170       +8     
- Misses       2318     2320       +2     
- Partials      302      303       +1

Flag	Coverage Δ
unittests	`45.27% <78.94%> (+0.06%)`	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...kg/yurtappmanager/controller/yurtappdaemon/util.go	`74.50% <76.92%> (+0.82%)`	:arrow_up:
...ntroller/yurtappdaemon/yurtappdaemon_controller.go	`19.25% <83.33%> (-0.55%)`	:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.