search

openyurtio / yurt-app-manager

The workload controller manager from NodePool level in OpenYurt cluster
Apache License 2.0
6 stars 1 forks source link

NodePool Spec Labels is gone #131

Open AndyEWang opened 1 year ago

AndyEWang commented 1 year ago

What happened: To add labels in NodePool Spec in api version v1beta1 but nothing is set.

What you expected to happen: spec.labels is expected in NodePool.

How to reproduce it (as minimally and precisely as possible): 1) deploy yurt-app-manager v0.6.0 2) create a nodepool with spec.labels in api version v1beta1 3) kubectl get nodepool -o yaml

Anything else we need to know?: suspect that pkg/yurtappmanager/apis/apps/v1beta1/nodepool_conversion.go leads to this. No labels field is converted between v1alpha1 and v1beta1.

    dst.Spec.Selector = src.Spec.Selector
    dst.Spec.Annotations = src.Spec.Annotations
    dst.Spec.Taints = src.Spec.Taints

Environment:

others

/kind bug

rambohe-ch commented 1 year ago

@kadisi PTAL