Closed kyakdan closed 1 year ago
@kyakdan: GitHub didn't allow me to assign the following users: your_reviewer.
Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide
Welcome @kyakdan! It looks like this is your first PR to openyurtio/yurt-app-manager 🎉
Merging #134 (aa67464) into master (a0346e5) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #134 +/- ##
=======================================
Coverage 45.21% 45.21%
=======================================
Files 42 42
Lines 4782 4782
=======================================
Hits 2162 2162
Misses 2318 2318
Partials 302 302
Flag | Coverage Δ | |
---|---|---|
unittests | 45.21% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@huiwq1990 PTAL
@kyakdan hi, could you order the import package? Make it match golint.
@huiwq1990 Thanks for the feedback. I've sorted the imports.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kyakdan, rambohe-ch
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Few imports were missing leading to build failures in OSS-Fuzz
What type of PR is this?
What this PR does / why we need it:
This PR fixes the yurtappset fuzzer so that the project can be fuzzed in OSS-Fuzz
Which issue(s) this PR fixes:
Fixes #133
Special notes for your reviewer:
Does this PR introduce a user-facing change? No
other Note