search

openyurtio / yurt-app-manager

The workload controller manager from NodePool level in OpenYurt cluster
Apache License 2.0
6 stars 1 forks source link

【feature request】YurtAppSet and YurtAppDaemon should support rollback #135

Open SQxiaoxiaomeng opened 1 year ago

SQxiaoxiaomeng commented 1 year ago

What would you like to be added: YurtAppSet and YurtAppDaemon should support rollback like Deployment

Why is this needed:

others /kind feature

rambohe-ch commented 1 year ago

@SQxiaoxiaomeng Thank you for raising issue. I think YurtAppSet can support rollback now. and you can update the specified nodePool template, then the underlying Deployment will rollback the pods in this NodePool.

rambohe-ch commented 1 year ago

@SQxiaoxiaomeng BTW, YurtAppDaemon looks like that can not support rollback strategy now.

SQxiaoxiaomeng commented 1 year ago

@rambohe-ch I'm sorry I didn't express clearly. What I want to say is that YurtAppSet should support rolling back to a certain historical version, just like kubectl rollout history deployment/xxx --revison=2，not to modify yaml.

rambohe-ch commented 1 year ago

@rambohe-ch I'm sorry I didn't express clearly. What I want to say is that YurtAppSet should support rolling back to a certain historical version, just like kubectl rollout history deployment/xxx --revison=2，not to modify yaml.

@SQxiaoxiaomeng Thank you for your kindly response. I think this feature requirement is quite reasonable. @kadisi Do you have any comments?