Closed xavier-hou closed 1 year ago
@xavier-hou: GitHub didn't allow me to assign the following users: your_reviewer.
Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: xavier-hou
To complete the pull request process, please assign kadisi
You can assign the PR to them by writing /assign @kadisi
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Merging #136 (67ff4f7) into master (d363b43) will increase coverage by
0.29%
. The diff coverage is47.45%
.
@@ Coverage Diff @@
## master #136 +/- ##
==========================================
+ Coverage 45.14% 45.44% +0.29%
==========================================
Files 42 47 +5
Lines 4782 5332 +550
==========================================
+ Hits 2159 2423 +264
- Misses 2320 2565 +245
- Partials 303 344 +41
Flag | Coverage Δ | |
---|---|---|
unittests | 45.44% <47.45%> (+0.29%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
...pmanager/webhook/staticpod/staticpod_validation.go | 13.88% <13.88%> (ø) |
|
...tappmanager/webhook/staticpod/staticpod_webhook.go | 30.43% <30.43%> (ø) |
|
...nager/controller/staticpod/staticpod_controller.go | 39.31% <39.31%> (ø) |
|
pkg/yurtappmanager/controller/staticpod/util.go | 65.65% <65.65%> (ø) |
|
...nager/controller/staticpod/info/static_pod_info.go | 79.74% <79.74%> (ø) |
|
...manager/controller/nodepool/nodepool_controller.go | 57.77% <0.00%> (+1.01%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Signed-off-by: hxcGit houxc_mail@163.com
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note