Closed SQxiaoxiaomeng closed 10 months ago
@SQxiaoxiaomeng: GitHub didn't allow me to assign the following users: your_reviewer.
Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: SQxiaoxiaomeng
To complete the pull request process, please assign rambohe-ch
You can assign the PR to them by writing /assign @rambohe-ch
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Welcome @SQxiaoxiaomeng! It looks like this is your first PR to openyurtio/yurt-app-manager 🎉
Merging #140 (a5f916d) into master (d363b43) will increase coverage by
0.06%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #140 +/- ##
==========================================
+ Coverage 45.14% 45.21% +0.06%
==========================================
Files 42 42
Lines 4782 4782
==========================================
+ Hits 2159 2162 +3
+ Misses 2320 2318 -2
+ Partials 303 302 -1
Flag | Coverage Δ | |
---|---|---|
unittests | 45.21% <ø> (+0.06%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
...manager/controller/nodepool/nodepool_controller.go | 57.77% <0.00%> (+1.01%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@kadisi PTAL
// +kubebuilder:pruning:PreserveUnknownFields
was missing leading topatch
has been prunedWhat type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #139
Special notes for your reviewer:
@kadisi @rambohe-ch
Does this PR introduce a user-facing change?
other Note