search

openyurtio / yurt-app-manager

The workload controller manager from NodePool level in OpenYurt cluster
Apache License 2.0
6 stars 1 forks source link

yurt-app-manager support YurtAppDaemon CRD #27

Closed kadisi closed 2 years ago

kadisi commented 3 years ago

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind feature

What this PR does / why we need it:

In the edge scenario, compute nodes in different regions are assigned to the same node pool. We expect some workload to be created automatically with the creation of the node pool. No additional human intervention is required.

ref: https://github.com/openyurtio/openyurt/issues/433 ref: https://github.com/openyurtio/openyurt/pull/422

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/assign @rambohe-ch @Fei-Guo

Please focus on the following files： /pkg/yurtappmanager/controller/yurtappdaemon/yurtappdaemon_controller.go /yurtappmanager/webhook/yurtappdaemon/mutating/yurtappdaemon_create_update_handler.go r/pkg/yurtappmanager/webhook/yurtappdaemon/validating/yurtappdaemon_create_update_handler.go

Does this PR introduce a user-facing change?

other Note

kadisi commented 2 years ago

@rambohe-ch PTAL

rambohe-ch commented 2 years ago

/lgtm /approve

openyurt-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadisi, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openyurtio/yurt-app-manager/blob/master/OWNERS)~~ [kadisi,rambohe-ch] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment