search

openyurtio / yurt-app-manager

The workload controller manager from NodePool level in OpenYurt cluster
Apache License 2.0
6 stars 1 forks source link

use https[s] proxy in docker for release build if necessary #28

Closed gnunu closed 2 years ago

gnunu commented 2 years ago

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line: /kind bug /kind documentation /kind enhancement /kind good-first-issue /kind feature /kind question /kind design /sig ai /sig iot /sig network /sig storage /sig storage

/kind bug

What this PR does / why we need it:

When build release from a proxy env, http[s]_proxy is needed within the build container.

same as: https://github.com/openyurtio/openyurt/pull/598

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/assign @kadisi @rambohe-ch

Does this PR introduce a user-facing change?

NONE

other Note

openyurt-bot commented 2 years ago

@gnunu: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/openyurtio/yurt-app-manager/pull/28): > > > >#### What type of PR is this? >> Uncomment only one ` /kind <>` line, hit enter to put that in a new line, and remove leading whitespace from that line: >> /kind bug >> /kind documentation >> /kind enhancement >> /kind good-first-issue >> /kind feature >> /kind question >> /kind design >> /sig ai >> /sig iot >> /sig network >> /sig storage >> /sig storage > >/kind bug > >#### What this PR does / why we need it: >When build release from a proxy env, http[s]_proxy is needed within the build container. > >same as: >https://github.com/openyurtio/openyurt/pull/598 > >#### Which issue(s) this PR fixes: > >Fixes # > >#### Special notes for your reviewer: > >/assign @kadisi @rambohe-ch > >#### Does this PR introduce a user-facing change? > >```release-note >NONE >``` > >#### other Note > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
gnunu commented 2 years ago

@kadisi please review and merge this patch, useful for proxy env. :)

kadisi commented 2 years ago

/lgtm /approve

openyurt-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnunu, kadisi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openyurtio/yurt-app-manager/blob/master/OWNERS)~~ [kadisi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kadisi commented 2 years ago

@gnunu tks