[BUG] a node'label will be deleted if it deleted from a nodepool that has the same label

[chenyufeifei]

What happened: First, I create a nodePool

cat <<EOF | kubectl apply -f -
apiVersion: apps.openyurt.io/v1alpha1
kind: NodePool
metadata:
  name: test
spec:
  type: Edge
  labels:
    foo: bar
EOF

Second, I add a label in a node

kubectl label nodes kind-worker foo=bar

Third, I add the node to the nodepool

kubectl label node  kind-worker apps.openyurt.io/desired-nodepool=test

Last, I delete the node from the nodePool

kubectl label node kind-worker apps.openyurt.io/desired-nodepool-

What you expected to happen:

The node should have a label foo=bar

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

I read the source code, find it record the nodePool related attribute. https://github.com/openyurtio/yurt-app-manager/blob/5dc7d07355df12cd63ebc3cb7692f601a932b7a1/pkg/yurtappmanager/controller/nodepool/nodepool_controller.go#L236-L241 https://github.com/openyurtio/yurt-app-manager/blob/5dc7d07355df12cd63ebc3cb7692f601a932b7a1/pkg/yurtappmanager/controller/nodepool/nodepool_controller.go#L325-L327

When the node delete from the nodepool, all label will be deleted include the same label.

https://github.com/openyurtio/yurt-app-manager/blob/5dc7d07355df12cd63ebc3cb7692f601a932b7a1/pkg/yurtappmanager/controller/nodepool/nodepool_controller.go#L268-L304

Environment:

• OpenYurt version:
• Kubernetes version (use kubectl version):
• OS (e.g: cat /etc/os-release):
• Kernel (e.g. uname -a):
• Install tools:
• Others:

others

/kind bug

[rambohe-ch]

@kadisi PTAL