search

openyurtio / yurt-app-manager

The workload controller manager from NodePool level in OpenYurt cluster
Apache License 2.0
6 stars 1 forks source link

support k8s 1.22 #49

Closed huiwq1990 closed 2 years ago

huiwq1990 commented 2 years ago

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line: /kind bug /kind documentation /kind enhancement /kind good-first-issue /kind feature /kind question /kind design /sig ai /sig iot /sig network /sig storage /sig storage

What this PR does / why we need it:

support k8s 1.22, it should cooperate with https://github.com/openyurtio/openyurt/pull/809

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

openyurt-bot commented 2 years ago

@huiwq1990: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/openyurtio/yurt-app-manager/pull/49): > > > >#### What type of PR is this? >> Uncomment only one ` /kind <>` line, hit enter to put that in a new line, and remove leading whitespace from that line: >> /kind bug >> /kind documentation >> /kind enhancement >> /kind good-first-issue >/kind feature >> /kind question >> /kind design >> /sig ai >> /sig iot >> /sig network >> /sig storage >> /sig storage > > > >#### What this PR does / why we need it: > >support k8s 1.22, it should cooperate with https://github.com/openyurtio/openyurt/pull/809 > >#### Which issue(s) this PR fixes: > >Fixes # > >#### Special notes for your reviewer: > > > >#### Does this PR introduce a user-facing change? > >```release-note > >``` > >#### other Note > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
rambohe-ch commented 2 years ago

/assign @kadisi @zzguang

rambohe-ch commented 2 years ago

/assign @kadisi @zzguang

zzguang commented 2 years ago

@huiwq1990 YurtIngress source code has been updated to add some enhancement features, could you please update this PR based on the latest source code? Sorry for the code conflict.

huiwq1990 commented 2 years ago

@zzguang Already fix it.

zzguang commented 2 years ago

Hi, @huiwq1990 : @adamzhoul submitted a PR to support k8s 1.22 for yurt-app-manager as well: https://github.com/openyurtio/yurt-app-manager/pull/56 I checked both of your PRs and found that your changes differ much with each other, so could you please cross review with @adamzhoul and submit an unified PR after your discussion? Thanks!

zzguang commented 2 years ago

/lgtm

openyurt-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huiwq1990, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openyurtio/yurt-app-manager/blob/master/OWNERS)~~ [rambohe-ch] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
adamzhoul commented 2 years ago

hi @huiwq1990 can you help update config/setup/all_in_one.yaml as well. otherwise, it's difficult to install

thanks