openyurtio / yurt-app-manager

The workload controller manager from NodePool level in OpenYurt cluster
Apache License 2.0
6 stars 1 forks source link

【FIX】fix revisionHistoryLimit is not exist #54

Closed JameKeal closed 2 years ago

JameKeal commented 2 years ago

What type of PR is this?

/kind bug

What this PR does / why we need it:

When I deploy yurt-app-manager, and the cluster is also have some uniteddeployment, the yurt-app-manager is not run success, the error is: image image

The reason is ud.Spec.RevisionHistoryLimit is not exist, but the code use it's pointer to get the value.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

openyurt-bot commented 2 years ago

@JameKeal: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/openyurtio/yurt-app-manager/pull/54): > > > >#### What type of PR is this? >> /kind bug > > > >#### What this PR does / why we need it: >When I deploy yurt-app-manager, and the cluster is also have some uniteddeployment, the yurt-app-manager is not run success, the error is: >![image](https://user-images.githubusercontent.com/70508195/168558744-e113f429-7464-4d3d-991d-ddf024501f83.png) >![image](https://user-images.githubusercontent.com/70508195/168558807-5f93d7ff-1c79-4f0a-bc87-07eb03703985.png) > >The reason is `ud.Spec.RevisionHistoryLimit` is not exist, but the code use it's pointer to get the value. > >#### Which issue(s) this PR fixes: > >Fixes # > >#### Special notes for your reviewer: > > > >#### Does this PR introduce a user-facing change? > >```release-note > >``` > >#### other Note > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
rambohe-ch commented 2 years ago

/lgtm /approve

openyurt-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JameKeal, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openyurtio/yurt-app-manager/blob/master/OWNERS)~~ [rambohe-ch] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment