Closed adamzhoul closed 2 years ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: adamzhoul
To complete the pull request process, please assign fei-guo
You can assign the PR to them by writing /assign @fei-guo
in a comment when ready.
The full list of commands accepted by this bot can be found here.
@adamzhoul Very appreciate for your job to adapt K8s v1.22 for yurt-app-manager. and i think we should review this pull request as quickly as possible so yurt-app-manager can support K8s v1.22. @kadisi @zzguang please take a look.
/assign @kadisi @zzguang
Hi, @adamzhoul: @huiwq1990 submitted a PR to support k8s 1.22 for yurt-app-manager before: https://github.com/openyurtio/yurt-app-manager/pull/49 I checked both of your PRs and found that your changes differ much with each other, so could you please cross review with @huiwq1990 and submit an unified PR after your discussion? Thanks!
@adamzhoul @zzguang I think the most important is we should change to go.mod
file. This PR does not upgrade k8s dependence to 1.22.3.
@zzguang @huiwq1990 @rambohe-ch thanks for the review
@huiwq1990 I think the update in https://github.com/openyurtio/yurt-app-manager/pull/49 contains updates here and more. so, I think we can close pr here.
But, pr #49 should be merged soon.
What type of PR is this?
What this PR does / why we need it:
Since openYurt is fully supports the k8s v1.22 This project should support it as well.
Which issue(s) this PR fixes:
Fixes: https://github.com/openyurtio/openyurt/issues/680
What does this pr include:
From v1.22 ChangeLog, we can see: It removes :
To support k8s v1.22. I have to upgrade our crd and webhook.
To support crd from apiextensions.k8s.io/v1beta1 -> apiextensions.k8s.io/v1. Have done:
To support webhook from admissionregistration/v1beta1 -> admissionregistration/v1. Have done:
Run
make generate-manifests
regenerate crd and webhook yamlRun
make generate-deploy-yaml
andcat _output/yamls/yurt-app-manager.yaml > config/setup/all_in_one.yaml
Finally, update hack/lib/release-images.sh to accelerate debug build time
Related resources: https://kubernetes.io/blog/2021/07/14/upcoming-changes-in-kubernetes-1-22/#api-changes https://kubernetes.io/docs/reference/access-authn-authz/extensible-admission-controllers/ https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#specifying-a-structural-schema admissionregistration/v1