openyurtio / yurt-app-manager

The workload controller manager from NodePool level in OpenYurt cluster
Apache License 2.0
6 stars 1 forks source link

feature: support k8s v1.22 #56

Closed adamzhoul closed 2 years ago

adamzhoul commented 2 years ago

What type of PR is this?

/kind feature

What this PR does / why we need it:

Since openYurt is fully supports the k8s v1.22 This project should support it as well.

Which issue(s) this PR fixes:

Fixes: https://github.com/openyurtio/openyurt/issues/680

What does this pr include:

From v1.22 ChangeLog, we can see: It removes :

To support k8s v1.22. I have to upgrade our crd and webhook.

Related resources: https://kubernetes.io/blog/2021/07/14/upcoming-changes-in-kubernetes-1-22/#api-changes https://kubernetes.io/docs/reference/access-authn-authz/extensible-admission-controllers/ https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#specifying-a-structural-schema admissionregistration/v1

openyurt-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adamzhoul To complete the pull request process, please assign fei-guo You can assign the PR to them by writing /assign @fei-guo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openyurtio/yurt-app-manager/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rambohe-ch commented 2 years ago

@adamzhoul Very appreciate for your job to adapt K8s v1.22 for yurt-app-manager. and i think we should review this pull request as quickly as possible so yurt-app-manager can support K8s v1.22. @kadisi @zzguang please take a look.

rambohe-ch commented 2 years ago

/assign @kadisi @zzguang

zzguang commented 2 years ago

Hi, @adamzhoul: @huiwq1990 submitted a PR to support k8s 1.22 for yurt-app-manager before: https://github.com/openyurtio/yurt-app-manager/pull/49 I checked both of your PRs and found that your changes differ much with each other, so could you please cross review with @huiwq1990 and submit an unified PR after your discussion? Thanks!

huiwq1990 commented 2 years ago

@adamzhoul @zzguang I think the most important is we should change to go.mod file. This PR does not upgrade k8s dependence to 1.22.3.

adamzhoul commented 2 years ago

@zzguang @huiwq1990 @rambohe-ch thanks for the review

@huiwq1990 I think the update in https://github.com/openyurtio/yurt-app-manager/pull/49 contains updates here and more. so, I think we can close pr here.

But, pr #49 should be merged soon.