search

openyurtio / yurt-app-manager

The workload controller manager from NodePool level in OpenYurt cluster
Apache License 2.0
6 stars 1 forks source link

use kube-webhook-certgen generate cert #81

Closed huiwq1990 closed 2 years ago

huiwq1990 commented 2 years ago

Signed-off-by: huiwq1990 huiwq1990@163.com

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line: /kind bug /kind documentation /kind enhancement /kind good-first-issue /kind feature /kind question /kind design /sig ai /sig iot /sig network /sig storage /sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #https://github.com/openyurtio/openyurt/issues/893

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

As, jet/kube-webhook-certgen not support v1 version ValidatingWebhookConfiguration, I use oamdev/kube-webhook-certgen to process webhooks. I will maintian openyurt's kube-webhook-certgen later.

openyurt-bot commented 2 years ago

@huiwq1990: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/openyurtio/yurt-app-manager/pull/81): >Signed-off-by: huiwq1990 > > > > >#### What type of PR is this? >> Uncomment only one ` /kind <>` line, hit enter to put that in a new line, and remove leading whitespace from that line: >> /kind bug >> /kind documentation >/kind enhancement >> /kind good-first-issue >> /kind feature >> /kind question >> /kind design >> /sig ai >> /sig iot >> /sig network >> /sig storage >> /sig storage > > > >#### What this PR does / why we need it: > >#### Which issue(s) this PR fixes: > >Fixes #https://github.com/openyurtio/openyurt/issues/893 > >#### Special notes for your reviewer: > > > >#### Does this PR introduce a user-facing change? > >```release-note > >``` > >#### other Note > > >As, [jet/kube-webhook-certgen](https://github.com/jet/kube-webhook-certgen) not support v1 version ValidatingWebhookConfiguration, I use `oamdev/kube-webhook-certgen` to process webhooks. I will maintian openyurt's kube-webhook-certgen later. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
codecov[bot] commented 2 years ago

Codecov Report

Merging #81 (af01852) into master (cdd3a0c) will not change coverage. The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #81   +/-   ##
======================================
  Coverage    7.78%   7.78%           
======================================
  Files          17      17           
  Lines        1901    1901           
======================================
  Hits          148     148           
  Misses       1724    1724           
  Partials       29      29
Flag Coverage Δ
unittests 7.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us.

rambohe-ch commented 2 years ago

@huiwq1990 I think it's not a good idea to maintain a unique kube-webhook-certgen for OpenYurt. how about post a pull request for supporting v1 version of ValidatingWebhookConfiguration to jet/kube-webhook-certgen?

rambohe-ch commented 2 years ago

@huiwq1990 please fix go.mod file conflict.

huiwq1990 commented 2 years ago

@huiwq1990 I think it's not a good idea to maintain a unique kube-webhook-certgen for OpenYurt. how about post a pull request for supporting v1 version of ValidatingWebhookConfiguration to jet/kube-webhook-certgen?

Ok, it maybe take some time to sovle the issue, so currently we use oamdev/kube-webhook-certgen whether it's ok.

rambohe-ch commented 2 years ago

/lgtm /approve

openyurt-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huiwq1990, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openyurtio/yurt-app-manager/blob/master/OWNERS)~~ [rambohe-ch] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment