rudolf-chy commented 2 years ago

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line: /kind bug /kind documentation /kind enhancement /kind good-first-issue /kind feature /kind question /kind design /sig ai /sig iot /sig network /sig storage /sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

openyurt-bot commented 2 years ago

@Rudolf1998: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/openyurtio/yurt-app-manager/pull/86): > > > >#### What type of PR is this? >> Uncomment only one ` /kind <>` line, hit enter to put that in a new line, and remove leading whitespace from that line: >> /kind bug >> /kind documentation >> /kind enhancement >> /kind good-first-issue >> /kind feature >> /kind question >> /kind design >> /sig ai >> /sig iot >> /sig network >> /sig storage >> /sig storage > > > >#### What this PR does / why we need it: > >#### Which issue(s) this PR fixes: > >Fixes # > >#### Special notes for your reviewer: > > > >#### Does this PR introduce a user-facing change? > >```release-note > >``` > >#### other Note > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

Congrool commented 2 years ago

Fixes #75

rudolf-chy commented 2 years ago

/assign @huangyuqi

codecov[bot] commented 2 years ago

Codecov Report

Merging #86 (3a1e83b) into master (cdd3a0c) will increase coverage by 0.36%. The diff coverage is n/a.

@@            Coverage Diff            @@
##           master     #86      +/-   ##
=========================================
+ Coverage    7.78%   8.15%   +0.36%     
=========================================
  Files          17      24       +7     
  Lines        1901    2613     +712     
=========================================
+ Hits          148     213      +65     
- Misses       1724    2364     +640     
- Partials       29      36       +7

Flag	Coverage Δ
unittests	`8.15% <ø> (+0.36%)`	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...urtappmanager/controller/yurtappdaemon/revision.go	`9.37% <0.00%> (ø)`
...ontroller/yurtappdaemon/workloadcontroller/util.go	`85.71% <0.00%> (ø)`
...oller/yurtappdaemon/workloadcontroller/workload.go	`0.00% <0.00%> (ø)`
...daemon/workloadcontroller/deployment_controller.go	`0.00% <0.00%> (ø)`
...kg/yurtappmanager/controller/yurtappdaemon/util.go	`71.05% <0.00%> (ø)`
...ntroller/yurtappdaemon/yurtappdaemon_controller.go	`0.67% <0.00%> (ø)`
...troller/yurtappdaemon/nodepool_enqueue_handlers.go	`0.00% <0.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

rambohe-ch commented 2 years ago

/lgtm /approve

openyurt-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, Rudolf1998

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openyurtio/yurt-app-manager/blob/master/OWNERS)~~ [rambohe-ch] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openyurtio / yurt-app-manager

add yurtappdaemon controller unit test #86