huiwq1990 commented 2 years ago

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line: /kind bug /kind documentation /kind enhancement /kind good-first-issue /kind feature /kind question /kind design /sig ai /sig iot /sig network /sig storage /sig storage

What this PR does / why we need it:

1) upgrade controller-runtime version 2) webhook code testable

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

openyurt-bot commented 2 years ago

@huiwq1990: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/openyurtio/yurt-app-manager/pull/88): > > > >#### What type of PR is this? >> Uncomment only one ` /kind <>` line, hit enter to put that in a new line, and remove leading whitespace from that line: >> /kind bug >> /kind documentation >/kind enhancement >> /kind good-first-issue >> /kind feature >> /kind question >> /kind design >> /sig ai >> /sig iot >> /sig network >> /sig storage >> /sig storage > > > >#### What this PR does / why we need it: >1) upgrade controller-runtime version >2) webhook code testable >#### Which issue(s) this PR fixes: > >Fixes # > >#### Special notes for your reviewer: > > > >#### Does this PR introduce a user-facing change? > >```release-note > >``` > >#### other Note > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

codecov[bot] commented 2 years ago

Codecov Report

Merging #88 (32953f7) into master (8d865d2) will increase coverage by 7.90%. The diff coverage is 49.50%.

:exclamation: Current head 32953f7 differs from pull request most recent head 7f76e05. Consider uploading reports for the commit 7f76e05 to get more accurate results

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage    7.78%   15.69%   +7.90%     
==========================================
  Files          17       20       +3     
  Lines        1901     2498     +597     
==========================================
+ Hits          148      392     +244     
- Misses       1724     2037     +313     
- Partials       29       69      +40

Flag	Coverage Δ
unittests	`15.69% <49.50%> (+7.90%)`	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../webhook/yurtappdaemon/yurtappdaemon_validation.go	`47.36% <ø> (ø)`
...anager/webhook/yurtappset/yurtappset_validation.go	`44.64% <ø> (ø)`
...ger/webhook/yurtappdaemon/yurtappdaemon_webhook.go	`46.00% <46.00%> (ø)`
...ppmanager/webhook/yurtappset/yurtappset_webhook.go	`52.94% <52.94%> (ø)`
...r/controller/yurtingress/yurtingress_controller.go	`17.64% <0.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Congrool commented 2 years ago

Fixes #78

huiwq1990 commented 2 years ago

@Congrool @rambohe-ch

Congrool commented 2 years ago

Thanks for your contribution. But I'm not familiar with how to generate webhook with controller-runtime. It will take some time. Anyone else that can help review this pr is also welcome.

rambohe-ch commented 2 years ago

/lgtm /approve

openyurt-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huiwq1990, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openyurtio/yurt-app-manager/blob/master/OWNERS)~~ [rambohe-ch] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openyurtio / yurt-app-manager

validate and mutate webhook upgrade #88