Closed Congrool closed 2 years ago
@Congrool: GitHub didn't allow me to assign the following users: your_reviewer.
Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide
Merging #94 (8e8ad2d) into master (23956e8) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #94 +/- ##
======================================
Coverage 9.34% 9.34%
======================================
Files 18 18
Lines 2258 2258
======================================
Hits 211 211
Misses 2010 2010
Partials 37 37
Flag | Coverage Δ | |
---|---|---|
unittests | 9.34% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us.
@Congrool It's a good idea to check go mod for pull request, maybe we can also add this feature for other repos.
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Congrool, rambohe-ch
The full list of commands accepted by this bot can be found here.
The pull request process is described here
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Congrool, rambohe-ch
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@Congrool It's a good idea to check go mod for pull request, maybe we can also add this feature for other repos.
Sure, I'll add it to openyurt repo as well.
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
Currently, we have no way to check if
go.mod
in a pr has been tidied. We should do that to make sure all pr has rungo mod tidy
before being merged.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note