Closed luc99hen closed 2 years ago
@luc99hen: GitHub didn't allow me to assign the following users: your_reviewer.
Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide
/assign @rambohe-ch
Merging #97 (ac49250) into master (ffb2bc9) will increase coverage by
4.05%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #97 +/- ##
==========================================
+ Coverage 21.21% 25.27% +4.05%
==========================================
Files 21 25 +4
Lines 2550 2742 +192
==========================================
+ Hits 541 693 +152
- Misses 1932 1951 +19
- Partials 77 98 +21
Flag | Coverage Δ | |
---|---|---|
unittests | 25.27% <ø> (+4.05%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
...manager/webhook/yurtingress/yurtingress_webhook.go | 24.44% <0.00%> (ø) |
|
...urtappmanager/webhook/nodepool/nodepool_webhook.go | 40.42% <0.00%> (ø) |
|
...ager/webhook/yurtingress/yurtingress_validating.go | 46.15% <0.00%> (ø) |
|
...appmanager/webhook/nodepool/nodepool_validation.go | 37.50% <0.00%> (ø) |
|
...manager/controller/nodepool/nodepool_controller.go | 57.77% <0.00%> (+2.36%) |
:arrow_up: |
...r/controller/nodepool/nodepool_enqueue_handlers.go | 86.90% <0.00%> (+86.90%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: luc99hen, rambohe-ch
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@luc99hen it's better rebase master
What type of PR is this?
What this PR does / why we need it:
add np webhook unit test & complement np controller test
Which issue(s) this PR fixes:
Fixes # https://github.com/openyurtio/yurt-app-manager/issues/73
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note