Closed huiwq1990 closed 2 years ago
@huiwq1990: GitHub didn't allow me to assign the following users: your_reviewer.
Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide
@huiwq1990 please fix the ci pipeline's errors.
Merging #98 (3acb802) into master (86623fb) will increase coverage by
0.54%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #98 +/- ##
==========================================
+ Coverage 21.33% 21.87% +0.54%
==========================================
Files 21 23 +2
Lines 2550 2647 +97
==========================================
+ Hits 544 579 +35
- Misses 1930 1986 +56
- Partials 76 82 +6
Flag | Coverage Δ | |
---|---|---|
unittests | 21.87% <ø> (+0.54%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
...manager/webhook/yurtingress/yurtingress_webhook.go | 24.44% <0.00%> (ø) |
|
...ager/webhook/yurtingress/yurtingress_validating.go | 46.15% <0.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: huiwq1990, rambohe-ch
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm /approve
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note