search

openyurtio / yurt-device-controller

This repository contains the device-controller that leverages EdgeX Foundry to manage edge devices
Apache License 2.0
14 stars 15 forks source link

add additional print columns to show more information #26

Closed qclc closed 2 years ago

qclc commented 2 years ago

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/assign @wawlian

Does this PR introduce a user-facing change?

This PR fixes a capital error in one of the CRD fields (deviceProfile.status.Synced -> deviceProfile.status.synced). This CRD is incompatible with v0.1.0 Yurt-Device-Controller. Therefore, the latest version of Yurt-Device-Controller is required when the CRD is applied.

other Note

openyurt-bot commented 2 years ago

@qclc: GitHub didn't allow me to assign the following users: wawlian, your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/openyurtio/yurt-device-controller/pull/26): > > > >#### What type of PR is this? >/kind enhancement > >#### What this PR does / why we need it: >- add additional print columns to show more information when using kubectl > >#### Which issue(s) this PR fixes: > >Fixes # > >#### Special notes for your reviewer: > >/assign @wawlian > >#### Does this PR introduce a user-facing change? > >This PR fixes a capital error in one of the CRD fields (`deviceProfile.status.Synced` -> `deviceProfile.status.synced`). This CRD is incompatible with v0.1.0 Yurt-Device-Controller. Therefore, the latest version of Yurt-Device-Controller is required when the CRD is applied. > >#### other Note > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openyurt-bot commented 2 years ago

@qclc: The label(s) kind/enhancement cannot be applied, because the repository doesn't have them

In response to [this](https://github.com/openyurtio/yurt-device-controller/pull/26): > > > >#### What type of PR is this? >/kind enhancement > >#### What this PR does / why we need it: >- add additional print columns to show more information when using kubectl > >#### Which issue(s) this PR fixes: > >Fixes # > >#### Special notes for your reviewer: > >/assign @wawlian > >#### Does this PR introduce a user-facing change? > >This PR fixes a capital error in one of the CRD fields (`deviceProfile.status.Synced` -> `deviceProfile.status.synced`). This CRD is incompatible with v0.1.0 Yurt-Device-Controller. Therefore, the latest version of Yurt-Device-Controller is required when the CRD is applied. > >#### other Note > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openyurt-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qclc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openyurtio/yurt-device-controller/blob/main/OWNERS)~~ [qclc] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
wawlian commented 2 years ago

@qclc maybe you can add short names for these three resource types in this pr.

qclc commented 2 years ago

@qclc maybe you can add short names for these three resource types in this pr.

The short names are added,please take a look. @wawlian

wawlian commented 2 years ago

/lgtm

openyurt-bot commented 2 years ago

@wawlian: changing LGTM is restricted to collaborators

In response to [this](https://github.com/openyurtio/yurt-device-controller/pull/26#issuecomment-1094709033): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.