search

openyurtio / yurt-device-controller

This repository contains the device-controller that leverages EdgeX Foundry to manage edge devices
Apache License 2.0
14 stars 15 forks source link

enhance tutorial v2 #38

Closed beiwei30 closed 2 years ago

beiwei30 commented 2 years ago

Signed-off-by: Ian Luo ian.luo@gmail.com

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line: /kind bug /kind documentation /kind enhancement /kind good-first-issue /kind feature /kind question /kind design /sig ai /sig iot /sig network /sig storage

What this PR does / why we need it:

Enhance tutorial to clarify command line arguments yurt-device-controller supports.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

openyurt-bot commented 2 years ago

@beiwei30: The label(s) kind/documentation cannot be applied, because the repository doesn't have them

In response to [this](https://github.com/openyurtio/yurt-device-controller/pull/38): >Signed-off-by: Ian Luo > > > > >#### What type of PR is this? >> Uncomment only one ` /kind <>` line, hit enter to put that in a new line, and remove leading whitespace from that line: >> /kind bug >/kind documentation >> /kind enhancement >> /kind good-first-issue >> /kind feature >> /kind question >> /kind design >> /sig ai >> /sig iot >> /sig network >> /sig storage > > > >#### What this PR does / why we need it: > >Enhance tutorial to clarify command line arguments yurt-device-controller supports. > >#### Which issue(s) this PR fixes: > >Fixes # > >#### Special notes for your reviewer: > > > >#### Does this PR introduce a user-facing change? > >```release-note > >``` > >#### other Note > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openyurt-bot commented 2 years ago

@beiwei30: The label(s) kind/documentation cannot be applied, because the repository doesn't have them

In response to [this](https://github.com/openyurtio/yurt-device-controller/pull/38): >Signed-off-by: Ian Luo > > > > >#### What type of PR is this? >> Uncomment only one ` /kind <>` line, hit enter to put that in a new line, and remove leading whitespace from that line: >> /kind bug > >/kind documentation > >> /kind enhancement >> /kind good-first-issue >> /kind feature >> /kind question >> /kind design >> /sig ai >> /sig iot >> /sig network >> /sig storage > > > >#### What this PR does / why we need it: > >Enhance tutorial to clarify command line arguments yurt-device-controller supports. > >#### Which issue(s) this PR fixes: > >Fixes # > >#### Special notes for your reviewer: > > > >#### Does this PR introduce a user-facing change? > >```release-note > >``` > >#### other Note > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openyurt-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: beiwei30 To complete the pull request process, please assign charleszheng44 You can assign the PR to them by writing /assign @charleszheng44 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openyurtio/yurt-device-controller/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openyurt-bot commented 2 years ago

@beiwei30: The label(s) kind/enhancement cannot be applied, because the repository doesn't have them

In response to [this](https://github.com/openyurtio/yurt-device-controller/pull/38): >Signed-off-by: Ian Luo > > > > >#### What type of PR is this? >> Uncomment only one ` /kind <>` line, hit enter to put that in a new line, and remove leading whitespace from that line: >> /kind bug >> /kind documentation >/kind enhancement >> /kind good-first-issue >> /kind feature >> /kind question >> /kind design >> /sig ai >> /sig iot >> /sig network >> /sig storage > > > >#### What this PR does / why we need it: > >Enhance tutorial to clarify command line arguments yurt-device-controller supports. > >#### Which issue(s) this PR fixes: > >Fixes # > >#### Special notes for your reviewer: > > > >#### Does this PR introduce a user-facing change? > >```release-note > >``` > >#### other Note > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openyurt-bot commented 2 years ago

@beiwei30: The label(s) kind/enhancement cannot be applied, because the repository doesn't have them

In response to [this](https://github.com/openyurtio/yurt-device-controller/pull/38): >Signed-off-by: Ian Luo > > > > >#### What type of PR is this? >> Uncomment only one ` /kind <>` line, hit enter to put that in a new line, and remove leading whitespace from that line: >> /kind bug >> /kind documentation > >/kind enhancement > >> /kind good-first-issue >> /kind feature >> /kind question >> /kind design >> /sig ai >> /sig iot >> /sig network >> /sig storage > > > >#### What this PR does / why we need it: > >Enhance tutorial to clarify command line arguments yurt-device-controller supports. > >#### Which issue(s) this PR fixes: > >Fixes # > >#### Special notes for your reviewer: > > > >#### Does this PR introduce a user-facing change? > >```release-note > >``` > >#### other Note > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
wawlian commented 2 years ago

/lgtm

wawlian commented 2 years ago

/approve