search

openyurtio / yurt-edgex-manager

yurt-edgex-manager is an operator for managing EdgeX lifecycle(including deploy, delete, update) in OpenYurt cluster.
Apache License 2.0
18 stars 24 forks source link

Fixed an issue where the kubebuilder framework could not deploy yurt-edgex-manager with webhook enabled #55

Closed LavenderQAQ closed 2 years ago

LavenderQAQ commented 2 years ago

What type of PR is this?

/kind bug The webhook switch of kubebuilder is enabled The webhook switch of controller is enabled in manager_config_patch.yaml. Call oamdev/kube-webhook-certgen by kustomize, webhook/job-patch is added to the config folder. In webhook/job-patch, a create job and two patch jobs are used. The create job is responsible for creating a certificate to the specified secret, and the patch jobs are responsible for repairing validating webhook and mutating webhook using CA from the corresponding secret.

What this PR does / why we need it:

As before, use make docker-build, make deploy and make undeploy to debug the program. Developers no longer need any environment variables.

Which issue(s) this PR fixes:

Fixes #54

codecov[bot] commented 2 years ago

Codecov Report

Merging #55 (769ecb6) into main (8a99c7d) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage   18.40%   18.40%           
=======================================
  Files           2        2           
  Lines         402      402           
=======================================
  Hits           74       74           
  Misses        322      322           
  Partials        6        6

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

LavenderQAQ commented 2 years ago

I changed the image tag in kustomize's config to "latest" and the image tag in helm to "v0.2.0". We can use helm as the release version and kustomize as the development version.