Assuming this 4GiB limit for zfs_dirty_data_max_max is intended, the documentation should be updated to reflect this. The man page for ZFS(4) should also be updated.
I'll also note that the zfs_dirty_data_max documentation should probably indicate that the default is MIN(10% of system RAM, zfs_dirty_data_max_max).
gmelikov
commented
1 year ago
The documentation for the
zfs_dirty_data_max_maxmodule parameter indicates that the default value is 25% of physical RAM: https://openzfs.github.io/openzfs-docs/Performance%20and%20Tuning/Module%20Parameters.html#zfs-dirty-data-max-maxIn the code,
zfs_dirty_data_max_maxis actually set to MIN(25% of system RAM, 4GiB): https://github.com/openzfs/zfs/blob/289f7e6adb58336281e87bffe853b280fc8ee498/module/zfs/arc.c#L8091Assuming this 4GiB limit for
zfs_dirty_data_max_maxis intended, the documentation should be updated to reflect this. The man page for ZFS(4) should also be updated.I'll also note that the
zfs_dirty_data_maxdocumentation should probably indicate that the default is MIN(10% of system RAM, zfs_dirty_data_max_max).