Fix missing options to accompany comments

[m3t]

In my eyes the comments related to X11 should be removed or else be amended by option examples. At least xkbOptions has to enclose the broken statement.

[ghost]

Thanks for the feedback!

Yes, the default config hints should be kept in sync with the config template generated by nixos-generate-config:

https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/installer/tools/tools.nix#L124

Can you also update the configuration-immutable.nix file, so that

diff configuration.nix configuration-immutable.nix

only outputs the differences necessary for implementing immutable root filesystem?

Thanks again!

m3t @.***> writes:

In my eyes the comments related to X11 should be removed or else be amended by option examples. At least xkbOptions has to enclose the broken statement. You can view, comment on, or merge this pull request online at:

https://github.com/openzfs/openzfs-docs/pull/389

-- Commit Summary --

• Fix missing options to accompany comments

-- File Changes --

M docs/Getting Started/NixOS/Root on ZFS/configuration.nix (3)

-- Patch Links --

https://github.com/openzfs/openzfs-docs/pull/389.patch https://github.com/openzfs/openzfs-docs/pull/389.diff

-- Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs-docs/pull/389 You are receiving this because you are subscribed to this thread.

Message ID: @.***>

[ghost]

@gmelikov LGTM. Approved.