search

openzfs / openzfs-docs

OpenZFS Documentation
https://openzfs.github.io/openzfs-docs/
135 stars 194 forks source link

Fedora Root on ZFS: Add a link to Greg\'s installation script #485

Closed gregory-lee-bartholomew closed 9 months ago

gregory-lee-bartholomew commented 10 months ago

People might find this script useful.

gmelikov commented 9 months ago

I'm not against such notes, but let's make them uniform, what do you think to make it same as in https://openzfs.github.io/openzfs-docs/Getting%20Started/openSUSE/openSUSE%20Leap%20Root%20on%20ZFS.html#notes ? It's important to make notes that it's an unofficial tool.

Another note - @ne9z made https://github.com/openzfs/openzfs-docs/blob/master/docs/Getting%20Started/Fedora/Root%20on%20ZFS.rst in a way that it may be at least tested in CI (so, commands can me merged in a script), if we mention other tools, then we should describe their differences.

ghost commented 9 months ago

Impressive! This PR looks good to me.

They make use of Kickstart, which works in a different way than the existing shell scripts, so CI tests maybe unnecessary in this case.

On Mon, Jan 29, 2024, 9:46 AM George Melikov @.***> wrote:

I'm not against such notes, but let's make them uniform, what do you think to make it same as in https://openzfs.github.io/openzfs-docs/Getting%20Started/openSUSE/openSUSE%20Leap%20Root%20on%20ZFS.html#notes ? It's important to make notes that it's an unofficial tool.

Another note - @ne9z https://github.com/ne9z made https://github.com/openzfs/openzfs-docs/blob/master/docs/Getting%20Started/Fedora/Root%20on%20ZFS.rst in a way that it may be at least tested in CI (so, commands can me merged in a script), if we mention other tools, then we should describe their differences.

— Reply to this email directly, view it on GitHub https://github.com/openzfs/openzfs-docs/pull/485#issuecomment-1914221015, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASN3TRJMT4XASHVOEGPPAOTYQ5OVVAVCNFSM6AAAAABCMYUN6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJUGIZDCMBRGU . You are receiving this because you were mentioned.Message ID: @.***>

gregory-lee-bartholomew commented 9 months ago

@gmelikov: Sure, I'm glad to adjust the style of this note to be more consistent with existing notes. Are you asking me to make a bullet point in the parent document instead of making an entirely separate page?

As for CI/CD tests, that would be cool. I don't have any experience setting those up. This script is entirely text-based, so if your environment has all the dependencies (e.g., rpm2cpio) and something like expect, I think it could be done. Maybe that would be a task for another time though?

gmelikov commented 9 months ago

I propose to add a link as a note in https://github.com/openzfs/openzfs-docs/blob/master/docs/Getting%20Started/Fedora/Root%20on%20ZFS.rst .

CI is not needed here at all, I've just wanted to describe our existing docs :) If you want to run some tests - it may be better to run them in your repository.

gregory-lee-bartholomew commented 9 months ago

@gmelikov: Is this now closer to what you have in mind? I'm happy to make further changes if you see anything that could use improvement. Just let me know. 🙂