search

openzfs / spl

A shim layer which adds the core interfaces required for OpenZFS.
https://zfsonlinux.org/
GNU General Public License v2.0
282 stars 181 forks source link

Fix reaping Linux kmem caches #658

Closed behlendorf closed 6 years ago

behlendorf commented 6 years ago

When the kmem cache is backed by a Linux slab cache requests to reap from the cache should be passed along.

Add missing parenthisis around btop and ptob macros to ensure operation ordering is preserved after expandsion.

tuxoko commented 6 years ago

We've been there before, but kmem_cache_shrink is not used for this purpose.

https://github.com/zfsonlinux/spl/pull/487

On Oct 9, 2017 2:25 PM, "Brian Behlendorf" notifications@github.com wrote:

@behlendorf https://github.com/behlendorf requested your review on: zfsonlinux/spl#658 https://github.com/zfsonlinux/spl/pull/658 Fix reaping Linux kmem caches.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/zfsonlinux/spl/pull/658#event-1284939082, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHTeHYJRnnkTlc0EPvF2NcdOWoAJEhCks5sqo9GgaJpZM4PxbeP .

behlendorf commented 6 years ago

Ahh yes. Thank you, I'd already forgotten about that. In that case, let me close this and simply fix the missing parenthesis.