Is 'CONFIG_TRIM_UNUSED_KSYMS' necessary when spl and zfs are built into the kernel?

openzfs / spl

A shim layer which adds the core interfaces required for OpenZFS.

https://zfsonlinux.org/

GNU General Public License v2.0

282 stars 181 forks source link

Is 'CONFIG_TRIM_UNUSED_KSYMS' necessary when spl and zfs are built into the kernel? #694

Closed twoertwein closed 6 years ago

twoertwein commented 6 years ago

Is it necessary to have CONFIG_TRIM_UNUSED_KSYMS disabled when ZFS and SPL are both compiled into the kernel? If it is possible to keep CONFIG_TRIM_UNUSED_KSYMS enabled when both are compiled into the kernel, it would be nice to have an option for configure to disable this check.

behlendorf commented 6 years ago

@twoertwein this could probably be relaxed for the builtin case. You can check if this is the case by commenting out the SPL_AC_CONFIG_TRIM_UNUSED_KSYMS check on line 27 in config/spl-build.m4. Patches welcome!

twoertwein commented 6 years ago

it builds and works perfectly even when CONFIG_TRIM_UNUSED_KSYMS is enabled (I called make menuconfig a second time to re-enable it). I think people who build ZFS into the kernel should be responsible to re-enable CONFIG_TRIM_UNUSED_KSYMS themselves. Except through a new option, SPL wouldn't know whether it will be built into the kernel.