openzfs / spl

A shim layer which adds the core interfaces required for OpenZFS.
https://zfsonlinux.org/
GNU General Public License v2.0
281 stars 180 forks source link

Compatibility request for linux 4.18 #706

Closed krrk closed 6 years ago

krrk commented 6 years ago

I cannot build spl using the latest rc kernel from Ubuntu: 4.18.0-041800rc3-generic.

Here is the error.

  CC [M]  spl/module/splat/splat-list.o
spl/module/spl/spl-vnode.c: In function ‘vn_getattr’:
spl/module/spl/spl-vnode.c:308:16: error: incompatible types when assigning to type ‘struct timespec’ from type ‘struct timespec64’
  vap->va_atime = stat.atime;
                ^
spl/module/spl/spl-vnode.c:309:16: error: incompatible types when assigning to typee ‘struct timespec64’
  vap->va_mtime = stat.mtime;
                ^
spl/module/spl/spl-vnode.c:310:16: error: incompatible types when assigning to typee ‘struct timespec64’
  vap->va_ctime = stat.ctime;
gmelikov commented 6 years ago

What is zfs and spl packages versions?

Stable branch is not compatible with 4.18 yet, please wait for next release https://github.com/zfsonlinux/zfs/releases

krrk commented 6 years ago

I am using commit 1149b62d (HEAD~1). This is just before preparing the repository for merging with zfs.

On Thu, Jul 5, 2018, 2:13 AM George Melikov notifications@github.com wrote:

What is zfs and spl packages versions?

Stable branch is not compatible with 4.18 yet, please wait for next release https://github.com/zfsonlinux/zfs/releases

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zfsonlinux/spl/issues/706#issuecomment-402616674, or mute the thread https://github.com/notifications/unsubscribe-auth/AEa-kLaE2oi2_S8W76hBVyL805JLBnjSks5uDa6fgaJpZM4VDCzg .

gmelikov commented 6 years ago

@krrk please see https://github.com/zfsonlinux/zfs/commit/6413c95fbd88dc06ae57e50398b8530a17d0c7d3 , it's already fixed in master.

Closed as fixed.

behlendorf commented 6 years ago

We expect to backport the 4.18 fixes for the 0.7.10 point release.

Nikratio commented 6 years ago

When is the next release planned? The previous releases seem to have been monthly, but the last one was in May.

tonyhutter commented 6 years ago

Apoligies @Nikratio, I've been slow on getting the next release out since I've been on baby bonding leave (and still am). I'd like to have the next release out before the OpenZFS conference on Sept 10th.

Nikratio commented 6 years ago

Congratulations! I hope everyone is well.

Could you say a few words about the release procedure? Are you simply taking a snapshot of master, or is there an extensive testing phase? I'm trying to decide if I can risk to compile from Git for now...

tonyhutter commented 6 years ago

I cherry pick from all the patches from the project page (https://github.com/zfsonlinux/zfs/projects/18) into the zfs-0.7-release branch, build/test them, and if everything looks good, build the RPMs and release it.

If you're just trying to get something stable working on the latest kernel right now, then checkout the zfs-0.7-release branch, and apply any compatibility patches until it builds for you.