search

openzfs / zfs-buildbot

The OpenZFS Buildbot Configuration
http://build.zfsonlinux.org
BSD 2-Clause "Simplified" License
25 stars 29 forks source link

Don't fail to install dependencies if kernel headers fail on Debian #262

Open rincebrain opened 1 year ago

rincebrain commented 1 year ago

As the buildbot shows right now, if the big monolithic apt-get command has a package missing (say, linux-headers-4.19.0-11-arm64), it will fail to install any of them.

Since breaking it into a bunch of install commands would increase the runtime substantially, just break out the headers install to a separate command, have it fall back to trying to install the latest headers for the arch anyway, and then install the other dependencies separately, so hopefully the erroring next time requires less digging to figure out the kernel headers were missing, not zlib1g-dev.

(Technically it having any headers could make it succeed and fail to load modules later, but since I suspect what's happening is the initial VM bringup is slightly too old so its headers are no longer in the repo, either we try with the latest headers assuming we're going to be using that kernel version, or we fail until someone updates the base VM.

If we want to be sure we boot the latest kernel, of course, we could explicitly install that...)

behlendorf commented 1 year ago

Sorry I missed this. The Debian repositories sorted out whatever their issue was but this still seems like a good idea. I'll see about getting it pulled in.