Open ChristophSchmidpeter opened 2 years ago
This issue has been automatically marked as "stale" because it has not had any activity for a while. It will be closed in 90 days if no further activity occurs. Thank you for your contributions.
I was able to confirm the unsorted error message on artix-6.6.34-1-lts
by compiling from source on the main branch. If 4 snapshots of a test dataset were created and named by creation time, the output of zfs destroy zroot/test
(using the freshly compiled binary) is still
use '-r' to destroy the following datasets:
zroot/test@3
zroot/test@4
zroot/test@2
zroot/test@1
The unsorted list seems to be pulled and printed at line 1381 in cmd/zfs/zfs_main.c
I will have a look at it and see what i can do to fix this. Will keep you updated.
System information
Describe the problem you're observing
When multiple snapshots prevent the destruction/rollback of the respective dataset/snapshot/volume via
zfs destroy
orzfs rollback
, the respective error message does not list the blocking snapshots sorted according to their order of creation.Describe how to reproduce the problem
The commands
result in the following error message:
Equivalent behaviour occurs when trying to roll back to a blocked snapshot, e.g. via
zfs rollback MyPool/Test@Snap1
Notice how, as mentioned, the resulting error message does not list the snapshots 1-6 in the order of their creation. This results in the error message being somewhat confusing/less intuitive and less informative and thus less useful. It also results in a less uniform behaviour, as
zfs list -t snap MyPool/Test
in contrast sorts the blocking snapshots in the order of their creation already:Include any warning/errors/backtraces from the system logs