robn
commented
7 months ago @lnicola thanks for the report.
What action were you taking when this happened. From the log, the process is SDMAIN, and its opening a file. Do you know any more about the file in question? And if you do, if it has any extended attributes?
When you say it was working before (at 8f2f6cd2ac), do you know if this same action was being taken then?
Initial analysis:
strcmp will dereference %rdi:
0f b6 14 07 movzbl (%rdi,%rax,1),%edxSo yes, its probably junk as the crash suggests.
nvt_lookup_name_type loads %rdi this:
49 8d 7c 24 28 lea 0x28(%r12),%rdiThat's the NVP_NAME lookup. i_nvp_t +0x10 is the start of the embedded nvpair_t; its nvp_name field is +0x18 beyond that.
for (i_nvp_t *e = entry; e != NULL; e = e->nvi_hashtable_next) {
if (strcmp(NVP_NAME(&e->nvi_nvp), name) == 0 &&%r12 also looks similarly un-pointer-ish in the crash dump (very nearby %rdi), so likely that's e at fault. Its probably the first pass through the loop, unless the chain of nvi_hashtable_next pointers is corrupt, but that feels less likely to me.
Regardless, entry comes straight out of the nvlist hashtable.
That nvlist is zp->z_xattr_cached, loaded straight up out of the SA area in zpl_xattr_get_sa(). So that suggests there's garbage on disk, or we made a mess of reading it?
"It worked fine" suggests a recent break. There's nothing obvious in this list of commits that are implicated, unless its something coincidental in the myriad page reading changes. I think that's unlikely though if this is a very reliable failure.
39be46f43 evansr 2024-03-29 Linux 5.18+ compat: Detect filemap_range_has_page
2553f94c4 evansr 2024-03-29 Fix buffer underflow if sysfs file is empty
cfb96c772 rob.nor.. 2024-03-29 vdev_disk: clean up spa/bdev mode conversion
c0aab8b8f f.gruen.. 2024-03-29 zvols: prevent overflow of minor device numbers
b1e46f869 george... 2024-03-29 Add ashift validation when adding devices to a pool
e39e20b6d evansr 2024-03-27 ZTS: fix flakiness in cp_files_002_pos
0c8eb974f mav 2024-03-27 BRT: Check pool clone stats in more tests
b40342762 mav 2024-03-27 BRT: Fix tests to work on non-empty pools
a89d209bb mav 2024-03-27 BRT: Fix holes cloning.
8cd8ccca5 mav 2024-03-25 BRT: Skip getting length in brt_entry_lookup()
c6be6ce17 rob.nor.. 2024-03-25 abd_iter_page: don't use compound heads on Linux <4.5
72fd834c4 rob.nor.. 2024-03-25 vdev_disk: use bio_chain() to submit multiple BIOs
df2169d14 rob.nor.. 2024-03-25 vdev_disk: add module parameter to select BIO submission method
06a196020 rob.nor.. 2024-03-25 vdev_disk: rewrite BIO filling machinery to avoid split pages
c4a13ba48 rob.nor.. 2024-03-25 vdev_disk: make read/write IO function configurable
867178ae1 rob.nor.. 2024-03-25 vdev_disk: reorganise vdev_disk_io_start
f3b85d706 rob.nor.. 2024-03-25 vdev_disk: rename existing functions to vdev_classic_*
390b44872 rob.nor.. 2024-03-25 abd: add page iterator
df04efe32 rob.nor.. 2024-03-25 linux 5.4 compat: page_size()
f68bde723 mav 2024-03-25 BRT: Make BRT block sizes configurable
493fcce9b george... 2024-03-25 Provide macros for setting and getting blkptr birth times
4616b96a6 mav 2024-03-25 BRT: Relax brt_pending_apply() locking
80cc51629 mav 2024-03-25 ZAP: Massively switch to _by_dnode() interfaces
bf8f72359 mav 2024-03-25 BRT: Skip duplicate BRT prefetches
102b468b5 rrevans 2024-03-25 Fix corruption caused by mmap flushing problems
c28f94f32 mav 2024-03-21 ZAP: Some cleanups/micro-optimizations
f1b368359 f.gruen.. 2024-03-21 udev: correctly handle partition #16 and later
2c01cae8b mav 2024-03-21 BRT: Change brt_pending_tree sorting order
5c4a4f82c rob.nor.. 2024-03-21 zio: update ZIO type x stage documentation
c9d8f6c59 harr1 2024-03-21 Fix option string, adding -e and fixing order
45e23abed mav 2024-03-20 Update resume token at object receive.
ef08a4d40 robn 2024-03-20 Linux 6.8 compat: use splice_copy_file_range() for fallback
90ff73235 robn 2024-03-20 freebsd: fix missing headers in distribution tarballHowever, just before that was 7a2e54b7d, which changed the test for the inode .permission member. I can't fathom how it could actually be related, but I see to words the same and I wonder.
That's all I have for now.
lnicola
rincebrain
System information
Describe the problem you're observing
Error message in the logs every two minutes.
2024.02.26.r9034.g8f2f6cd2ac_6.8.1.arch1.1-1was fine.Describe how to reproduce the problem
Don't know, I just upgraded and rebooted.
Include any warning/errors/backtraces from the system logs