Moved the comment (and de-shouted it) to where I think it should have been.
I wonder how necessary this really is. It's not wrong, but I expect there's lots of things that are stored on disk that aren't immediately obvious, so it feels weird to call out just this case. On the other hand, maybe this is just a step towards someday calling them all out, so its no big deal :)
How Has This Been Tested?
Comment change. no testing done.
Types of changes
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Performance enhancement (non-breaking change which improves efficiency)
[ ] Code cleanup (non-breaking change which makes code smaller or more readable)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
[x] Documentation (a change to man pages or other documentation)
[Sponsors: Klara, Inc., Wasabi Technology, Inc.]
Motivation and Context
A comment that confused me. Compression names actually aren't used in dedup table names, but checksum names are.
Was introduced in review https://github.com/openzfs/zfs/pull/15892#discussion_r1679835046.
Description
Moved the comment (and de-shouted it) to where I think it should have been.
I wonder how necessary this really is. It's not wrong, but I expect there's lots of things that are stored on disk that aren't immediately obvious, so it feels weird to call out just this case. On the other hand, maybe this is just a step towards someday calling them all out, so its no big deal :)
How Has This Been Tested?
Comment change. no testing done.
Types of changes
Checklist:
Signed-off-by.