lundman
commented
4 years ago Seems related to:
# lldb /Library/Filesystems/zfs.fs/Contents/Resources/zfs_util
(lldb) image lookup --verbose --address main+2139
Address: zfs_util[0x0000000100002403] (zfs_util.__TEXT.__text + 4419)
Summary: zfs_util`main + 2139 [inlined] zfs_probe_iokit + 40 at zfs_util.c:733
zfs_util`main + 2099 at zfs_util.c:733
Module: file = "/Library/Filesystems/zfs.fs/Contents/Resources/zfs_util", arch = "x86_64"
CompileUnit: id = {0x00000000}, file = "/Users/lundman/Developer/catalina/zfs/cmd/zfs_util/zfs_util.c", language = "c99"
Function: id = {0x100000aec}, name = "main", range = [0x0000000100001ba8-0x0000000100002458)
FuncType: id = {0x100000aec}, byte-size = 0, decl = zfs_util.c:609, compiler_type = "int (int, char **)"
Blocks: id = {0x100000aec}, range = [0x100001ba8-0x100002458)
id = {0x100000c86}, ranges = [0x100001e75-0x100001e96)[0x100001fe5-0x10000200f)[0x100002110-0x1000021f9)[0x1000023db-0x100002438), name = "zfs_probe_iokit", decl = zfs_util.c:418
LineEntry: [0x0000000100002403-0x000000010000240b): /Users/lundman/Developer/catalina/zfs/cmd/zfs_util/zfs_util.c:475:3
Symbol: id = {0x000009e8}, range = [0x0000000100001ba8-0x0000000100002484), name="main"
Variable: id = {0x100000c92}, name = "devpath", type = "const char *", location = , decl = zfs_util.c:418
Variable: id = {0x100000c97}, name = "args", type = "probe_args_t *", location = , decl = zfs_util.c:418
Variable: id = {0x100000c9c}, name = "result", type = "int", location = DW_OP_consts(0x-1) , decl = zfs_util.c:424
Variable: id = {0x100000ca5}, name = "cfstr", type = "CFStringRef", location = r15, decl = zfs_util.c:423
Variable: id = {0x100000cae}, name = "service", type = "io_service_t", location = r14, decl = zfs_util.c:422
Variable: id = {0x100000b26}, name = "blockdevice", type = "char [1024]", location = DW_OP_fbreg(-3200), decl = zfs_util.c:612
Variable: id = {0x100000b36}, name = "rawdevice", type = "char [1024]", location = DW_OP_fbreg(-2176), decl = zfs_util.c:613
Variable: id = {0x100000b46}, name = "volname", type = "char [1024]", location = DW_OP_fbreg(-4368), decl = zfs_util.c:626
Variable: id = {0x100000b56}, name = "pool_name", type = "char *", location = rbx, decl = zfs_util.c:627
Variable: id = {0x100000b86}, name = "what", type = "char", location = , decl = zfs_util.c:614
Variable: id = {0x100000bb2}, name = "i", type = "int", location = r13, decl = zfs_util.c:623
Variable: id = {0x100000bc2}, name = "sb", type = "stat", location = [rbp-3344], decl = zfs_util.c:618
Variable: id = {0x100000bf2}, name = "len", type = "int", location = DW_OP_consts(0x256) , decl = zfs_util.c:623
Variable: id = {0x100000c12}, name = "attr", type = "attrlist", location = , decl = zfs_util.c:624
Variable: id = {0x100000c1e}, name = "nameBuf", type = "attrNameBuf", location = , decl = zfs_util.c:625 cfstr = IORegistryEntryCreateCFProperty(service,
CFSTR("ZFS Dataset"), kCFAllocatorDefault, 0);
if (cfstr != NULL) {
(void) strlcpy(args->pool_name,
CFStringGetCStringPtr(cfstr,
kCFStringEncodingMacRoman),
sizeof (io_name_t));Makes me wonder what string is in your "ZFS Dataset". Ie, can you run:
# ioreg -al
and search for "ZFS Dataset". My test pool194 has:
<key>ZFS Dataset</key>
<string>pool194</string>
jawbroken
rejsmont
eejd
I have OpenZFS_on_OS_X_1.9.4 2020-02-29 installed on macOS Catalina 10.15.6. I'm getting crashes in zfs_util on every restart. They always seem to come in pairs, as follows.
Example pair:
zfs_util_2020-09-22-232650_fileserver.crash
zfs_util_2020-09-22-232739_tbfileserver.crash
I only see two uses of
strlcpyin zfsutil, here and here. The latter is perhaps more supicious, being introduced in this commit from April 2019 and mentioning diskarbitrationd, etc.