openzfsonwindows / openzfs

OpenZFS on Linux and FreeBSD
https://openzfs.github.io/openzfs-docs
Other
496 stars 18 forks source link

rc2: directory size is not reported (correctly) + some misc game testing #221

Open colemickens opened 1 year ago

colemickens commented 1 year ago

Again with RC2 on Windows.

Some miscellaneous testing:

  1. As noted in another bug (with other discussion, hence a new bug), directory sizes are not (yet) reported correctly.

  2. Steam forgets that games are installed, even after re-verifying contents. I have a hunch this is due to some early sanity check of directory size as if it thinks the game directory is empty and thus not installed. When verifying files, it will jump to 199%, and then if I pause/unpause it seems to realize the game files are there. However, games fail to launch and take down the entire Steam client. (And again, upon relaunching Steam doesn't see them installed despite the library folder being configured).

  3. Epic Games Store installs and recognizes that it has installed Fortnite, but Fortnite crashes on launch without much useful information. The EGS client remains running.

  4. Battle.Net happily installed and launched Overwatch 2 with zero fuss. I was able to queue for a game and get into the practice firing range.

lundman commented 1 year ago

The directory size thing is interesting, not the right-click-properties size? that was working at one point. Windows has so many ways to get the same information, it is hard to know which one they use.

FileSpy.exe will show which events they use, but a smaller test case would be nicer, than installing steam, then a game :)

colemickens commented 1 year ago
  1. Yes, this was just right-clicking in Explorer and going to Properties.

  2. I'll play around with FileSpy soon.

  3. I'll look out for a smaller test case, or maybe at least a tiny/free game that it might repro if nothing else. But I'm mostly just reporting for the sake of getting something out there for other curious folks, no expectations. I'm still in awe that this is in the state its in!

lundman commented 1 year ago

A quick run of filespy when doing a right-click/properties show:

Screenshot 2023-04-14 at 15 17 33 (2)

The two highlighted entries should be checked, method 37 and why dirlist fails.

lundman commented 1 year ago
 FileRemoteProtocolInformation,                  // 55

Should be harmless. More about the initial dirlist failure

lundman commented 1 year ago

Oh right, lost the search-pattern code during the cleanup. OK, I'll put it back in

lundman commented 1 year ago

NTFS issuing "Properties" on "New Folder/tools".

NTFS-properties

I'm interested in IOCTL_MOUNTDEV_QUERY_DEVICE_NAME returning STATUS_INVALID_PARAMETER. We always return the name of whatever the volume is above. Perhaps we should be returning error if the queries entry isn't the root.

lundman commented 1 year ago

OK asking chatGPT about why NTFS returns an error sometimes:

"If the IOCTL is sent to the volume handle, you should ensure that the handle refers to the root of the volume before processing the request. If the handle does not refer to the root of the volume, you should return STATUS_INVALID_PARAMETER error to indicate that the request is not valid for the specified device."

So trying that out, I can confirm I can now see the number of items and size of a directory.

lundman commented 1 year ago

If you have time, give rc3 a go, and see if helps

https://github.com/openzfsonwindows/openzfs/releases/tag/zfswin-2.1.7rc1

colemickens commented 1 year ago

So, right click -> properties now works for directories.

While Steam seems to be able to better verify Titanfall 2, all of the other behavior described above still holds true - I'm still unable to launch any Steam games, BattleNet COD, or EGS Fortnite. I am still able to run OW2 from Battle.Net though.

ra1nst0rm3d commented 1 year ago

@lundman Still don't working on rc4. Some games like Warface and Escape From Tarkov looks like... them is not binary file, but they actually is(?) image Should I look FileSpy?

P.S Tarkov is working buttery smooth, but Warface is not even launching: just drops without any error message

colemickens commented 1 year ago

Just to clarify @ra1nst0rm3d, do you expect Windows to show the file size for directories there? Or is there a different issue? I didn't understand the bit about binary files, since I can't read... Russian?

Might be worth closing this (especially since it says and was tested against rc2 for me) and opening a new one?

ra1nst0rm3d commented 1 year ago

Just to clarify @ra1nst0rm3d, do you expect Windows to show the file size for directories there? Or is there a different issue? I didn't understand the bit about binary files, since I can't read... Russian?

Might be worth closing this (especially since it says and was tested against rc2 for me) and opening a new one?

I except that EscapeFromTarkov should have icon (there is not) and Warface too... But Warface won't launch :( Also, tried SPT-AKI (patcher for Tarkov) and installer said, that EscapeFromTarkov.exe (!) not found. 0_0

lundman commented 1 year ago

OK good to know. there is an rc5 coming soon, but don't think I have fixed anything in the area that would make it appear as "not found".

EchterAgo commented 1 year ago

@ra1nst0rm3d have you ever compared the contents of the files? You can use HxD to compare the version on ZFS with the same file from an NTFS install. Go to Analysis | Data comparison... | Compare.

ra1nst0rm3d commented 1 year ago

Done some experiments under Linux: EFT under Wine works flawlessly. And patcher found executable successfully... Looks like problem in Windows compatibility layer :/

P.S. All done in same EFT copy, which was downloaded in Windows to ZFS partition

jonhermansen commented 1 year ago

Just to clarify @ra1nst0rm3d, do you expect Windows to show the file size for directories there? Or is there a different issue? I didn't understand the bit about binary files, since I can't read... Russian? Might be worth closing this (especially since it says and was tested against rc2 for me) and opening a new one?

I except that EscapeFromTarkov should have icon (there is not) and Warface too... But Warface won't launch :( Also, tried SPT-AKI (patcher for Tarkov) and installer said, that EscapeFromTarkov.exe (!) not found. 0_0

On ZFS 2.2.0rc6, Explorer does not show embedded icon images in executables. If you have a shortcut on desktop to an exe stored in ZFS, it also will not show the icon.