search

openzfsonwindows / openzfs

OpenZFS on Linux and FreeBSD
https://openzfs.github.io/openzfs-docs
Other
402 stars 15 forks source link

Key load error: Couldn't GET http://127.0.0.1:8080/xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx: No error #361

Open oldshensheep opened 3 months ago

oldshensheep commented 3 months ago

System information

Type Version/Name
Distribution Name Windows 11 Pro
Distribution Version 23H2
Kernel Version 22635.3212
Architecture x64
OpenZFS Version OpenZFSOnWindows-debug-in-2.2.3rc1.exe

Describe the problem you're observing

like https://github.com/openzfsonwindows/openzfs/issues/359 but new error

❯ zfs load-key -a
Key load error: Couldn't GET http://127.0.0.1:8080/xxxxxxxxxxxxxxxxxxxxxxxxxxxxx: No error
Key load error: Couldn't GET http://127.0.0.1:8080/yyyyyyyyyyyyyyyyyyyyyyyyyyyy: No error
0 / 2 key(s) successfully loaded
❯ curl http://127.0.0.1:8080/xxxxxxxxxxxxxxxxxxxxxxxxxxxxx
<something>

Describe how to reproduce the problem

Include any warning/errors/backtraces from the system logs

lundman commented 3 months ago

It was a pretty fast port - so it looks like it isn't bubbling the error back up.

lundman commented 3 months ago

Note to self, fetching successfully and errors does appear to work, but the call to getline() is incorrect, it has to handle the expansion by calling realloc() and setting *linep. Quite noticeable if verbose is enabled, as it tries to read into a NULL ptr.

Also seems ZFS has no way to pass Verbose into libfetch. Perhaps we should fetch from env vars.