search

openzim / _python-bootstrap

Sample openZIM Python project bootstrap
1 stars 2 forks source link

Fix coverage upload #44

Closed rgaudin closed 3 months ago

rgaudin commented 3 months ago

Usage of coverage stores data in the internal .coverage file that is not supported^1 by codecov. This results in silently (because we dont use fail option by default) not uploading coverage.

This fixes it by runnin coverage xml in coverage_report which outputs a compatible file in coverage.xml

1: https://docs.codecov.com/docs/supported-report-formats#non-supported-code-coverage-formats

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (3856ce2) to head (b141f30).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #44 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 1 1 Lines 8 8 Branches 1 1 ========================================= Hits 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rgaudin commented 3 months ago

Yes, I think we should have the fail option in the default ; let me add it here